This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Create Gemfiles with an HTTPS github source defined#5728
Merged
bundlerbot merged 1 commit intomasterfrom Jun 16, 2017
Merged
Conversation
|
@bundlerbot r+ |
Collaborator
|
📌 Commit 74adefe has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jun 16, 2017
Create Gemfiles with an HTTPS github source defined ### What was the end-user problem that led to this PR? The problem was that people are creating new Gemfiles that use the built-in `github` git source, which is being removed in 2.0. Additionally, it does _not_ use an encrypted connection to GitHub. ### Was was your diagnosis of the problem? My diagnosis was that we can't change the default because of backwards compatibility, but we can encourage _new_ Gemfiles to "do the right thing". ### What is your fix for the problem, implemented in this PR? My fix is to add our new, recommended definition of the shortcut to all bundler-generated gemfiles. ### Why did you choose this fix out of the possible options? I chose this fix because it will only affect new Gemfiles.
Collaborator
|
☀️ Test successful - status-travis |
segiddins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Create Gemfiles with an HTTPS github source defined ### What was the end-user problem that led to this PR? The problem was that people are creating new Gemfiles that use the built-in `github` git source, which is being removed in 2.0. Additionally, it does _not_ use an encrypted connection to GitHub. ### Was was your diagnosis of the problem? My diagnosis was that we can't change the default because of backwards compatibility, but we can encourage _new_ Gemfiles to "do the right thing". ### What is your fix for the problem, implemented in this PR? My fix is to add our new, recommended definition of the shortcut to all bundler-generated gemfiles. ### Why did you choose this fix out of the possible options? I chose this fix because it will only affect new Gemfiles. (cherry picked from commit d11d693) # Conflicts: # lib/bundler/templates/gems.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that people are creating new Gemfiles that use the built-in
githubgit source, which is being removed in 2.0. Additionally, it does not use an encrypted connection to GitHub.Was was your diagnosis of the problem?
My diagnosis was that we can't change the default because of backwards compatibility, but we can encourage new Gemfiles to "do the right thing".
What is your fix for the problem, implemented in this PR?
My fix is to add our new, recommended definition of the shortcut to all bundler-generated gemfiles.
Why did you choose this fix out of the possible options?
I chose this fix because it will only affect new Gemfiles.